-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle and Github changes for JRE 17 Min #5512
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I assume this will wait until 0.49.20 is released?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to note that by the time we merge this, the dependencies updates may become downgrades.
By the time we merge this, I'll do a cursory check to ensure they're updated. :) Here's hoping it is sooner rather than later. |
Gradle Build Updates.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5512 +/- ##
==========================================
Coverage 29.30% 29.31%
- Complexity 13783 13802 +19
==========================================
Files 2461 2463 +2
Lines 262663 262826 +163
Branches 47007 47033 +26
==========================================
+ Hits 76967 77038 +71
- Misses 181831 181915 +84
- Partials 3865 3873 +8 ☔ View full report in Codecov by Sentry. |
Actions are passing. Ready for merge. |
Given the approvals and moving up the 0.50.0 release merging these. |
These are the minimal changes needed for Java 17 as the minimal version.